Add bodyNotContains function#1271
Merged
snoyberg merged 4 commits intoyesodweb:masterfrom Sep 1, 2016
Merged
Conversation
| (simpleBody res) `contains` text | ||
|
|
||
| -- | Assert the last response doesn't have the given text. The check is performed using the response | ||
| -- body in full text form. |
Member
There was a problem hiding this comment.
Can you add a @since comment, as well as bump the .cabal version field and add a comment to the ChangeLog.md? This looks good.
Member
There was a problem hiding this comment.
Oh, also need to export the identifier from the module.
Member
|
The build fails on Travis. |
Contributor
Author
|
Tests seem to be fixed apart of one that is stuck. Maybe we should restart that test?
|
Member
|
Restarted |
Contributor
Author
|
The failing environment seems like it didn't restart. Should we move it to allowed failings? |
Member
|
I have restarted it again: https://travis-ci.org/yesodweb/yesod/jobs/156792968 |
Member
|
I merged to master since all seems to be in order. We'll see if it breaks the master build too somehow. |
Contributor
Author
|
Cool, thanks folks. Excited about my first yesod core PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR adds a function to assert a text doesn't appear in the body of the response