Update wai-eventsource to use Conduits.#29
Merged
gregwebs merged 1 commit intoyesodweb:masterfrom Jan 13, 2012
BardurArantsson:eventsource-conduits
Merged
Update wai-eventsource to use Conduits.#29gregwebs merged 1 commit intoyesodweb:masterfrom BardurArantsson:eventsource-conduits
gregwebs merged 1 commit intoyesodweb:masterfrom
BardurArantsson:eventsource-conduits
Conversation
Contributor
There was a problem hiding this comment.
(const ign) and (const $ fmap (f . eventToBuilder) $ readChan chan) might be better
Contributor
Author
There was a problem hiding this comment.
This has been prettified in my other pull request, thanks. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I needed an EventSource implementation for a little, so I've updated wai-eventsource to use Conduit.
The changes themselves should be uncontroversial, though perhaps not particularly elegant since this is my first stab at using conduits.
Cheers,