Skip to content

support @supports#263

Merged
snoyberg merged 3 commits intoyesodweb:masterfrom
jeongoon:master
Mar 4, 2022
Merged

support @supports#263
snoyberg merged 3 commits intoyesodweb:masterfrom
jeongoon:master

Conversation

@jeongoon
Copy link
Copy Markdown
Contributor

@jeongoon jeongoon commented Feb 28, 2022

Hi, I'm trying to add @supports.
I made some tests by referring @media.

but I don't know how to apply to my current setup right away to see the effects as well.
because I'm not a professional programmer.
is there any way to apply in my stack.yaml or equivalent one to compile with patched version?

@jeongoon
Copy link
Copy Markdown
Contributor Author

jeongoon commented Mar 1, 2022

I found how to compile yesod with patched shakespeare from stackoverflow.
compiling now. hopefully work as I wanted.

@snoyberg
Copy link
Copy Markdown
Member

snoyberg commented Mar 2, 2022

Have you had a chance to test this and see if it does what you're looking for?

@jeongoon
Copy link
Copy Markdown
Contributor Author

jeongoon commented Mar 2, 2022

Oh, I'm using my patched version now (on archlinux with lts 16.31 which included in scaffolding)
But i can see some test is failing here.
Any guide line to help?

@snoyberg
Copy link
Copy Markdown
Member

snoyberg commented Mar 2, 2022

The error seems to be unrelated to this PR. We can ignore in this PR.

celper "@media only screen {\n foo bar {\n baz: bin;\n }\n}\n" $(luciusFileDebug "test/cassiuses/external-media.lucius")
celper "@media only screen{foo bar{baz:bin}}" [lucius|
@media only screen{
celper "@media only screen {foo bar{baz:bin}}" [lucius|
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to see unrelated changes in this PR. This line specifically is present to test that things work both with and without extra spacing.

@jeongoon
Copy link
Copy Markdown
Contributor Author

jeongoon commented Mar 3, 2022

noted. I revert my changes which is note related to "@supports".
thank you.

@snoyberg snoyberg merged commit 6304dfe into yesodweb:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants