Updates for GHC 9 and template-haskell 2.17.#254
Merged
snoyberg merged 2 commits intoyesodweb:masterfrom Aug 28, 2020
Merged
Conversation
Member
|
Looks great, thanks! Could you add a minor version bump and a changelog entry about the change? |
snoyberg
approved these changes
Aug 28, 2020
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were changes I needed to build under the recently released
ghc-9.0.1-alpha, mostly due to Template Haskell 2.17 updates.Because of the
-XQualifiedDoextension,DoEnow takes an extra argument of aMaybe ModName.A newtype
Codewas added in https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3358, so that we useunsafeCodeCoerceinstead ofunsafeTExpCoerce.A function had to be explicitly generalized from
Q xto the newQuote m => m x.Because of https://github.com/ghc-proposals/ghc-proposals/blob/master/proposals/0229-whitespace-bang-patterns.rst,
($[])is interpreted as a splice rather than a slice. We just have to insert a space after the$.