Skip to content

Add stextFile to Text.Shakespeare.Text#240

Merged
snoyberg merged 1 commit intoyesodweb:masterfrom
lexi-lambda:stextFile
Oct 10, 2019
Merged

Add stextFile to Text.Shakespeare.Text#240
snoyberg merged 1 commit intoyesodweb:masterfrom
lexi-lambda:stextFile

Conversation

@lexi-lambda
Copy link
Copy Markdown
Contributor

@lexi-lambda lexi-lambda commented Oct 9, 2019

This adds stextFile to Text.Shakespeare.Text, which is to textFile as shamletFile is to hamletFile.

@snoyberg
Copy link
Copy Markdown
Member

snoyberg commented Oct 10, 2019

A few comments, could you please

  1. Add a minor version bump
  2. Add a ChangeLog entry
  3. Add some Haddocks explaining what this function does, including a @since annotation

@lexi-lambda
Copy link
Copy Markdown
Contributor Author

lexi-lambda commented Oct 10, 2019

@snoyberg Thanks, I’ve now done so.

snoyberg
snoyberg approved these changes Oct 10, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@snoyberg snoyberg merged commit 7c2da17 into yesodweb:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lexi-lambda @snoyberg