ToJavascript instance of String and Text#227
Merged
snoyberg merged 3 commits intoyesodweb:masterfrom Sep 25, 2018
Merged
Conversation
Author
|
issue ref: #226 |
snoyberg
requested changes
Sep 21, 2018
ChangeLog.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ### 2.0.18 | |||
|
|
|||
| * Text instance of String and Text [#227](https://github.com/yesodweb/shakespeare/pull/227) | |||
Member
There was a problem hiding this comment.
I think this should say ToJavascript instance, and point out that it's for both strict and lazy Text.
Member
There was a problem hiding this comment.
I think it should say ToJavascript instance for String, Strict and Lazy Text. Right now, it says Text instance for .... instead.
Author
There was a problem hiding this comment.
Um sorry, I'm not good at English. lol
06b7684 to
b913f78
Compare
b913f78 to
43475fe
Compare
snoyberg
approved these changes
Sep 25, 2018
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.