Skip to content

Stopped 'contentHash' from unnecesarily consuming hashes#198

Merged
snoyberg merged 2 commits intoyesodweb:masterfrom
terickson001:hamlet/class-id-spacing-fix
Dec 19, 2016
Merged

Stopped 'contentHash' from unnecesarily consuming hashes#198
snoyberg merged 2 commits intoyesodweb:masterfrom
terickson001:hamlet/class-id-spacing-fix

Conversation

@terickson001
Copy link
Copy Markdown
Contributor

@terickson001 terickson001 commented Dec 15, 2016

In response to issue #197.

This should fix the issue, however this is my first time using Parsec. If there's a more elegant solution for this, feel free.

Edit:
Hmm.. Seems I've overlooked something. First pull requests and all, forgot stack test. I'll see what I can do.

@terickson001
Copy link
Copy Markdown
Contributor Author

I had assumed parseVar was meant to only parse interpolation with a given leading character, but it seems it has some special cases that caused it to never fail (seems quite messy in there).
Should be fixed now.

@snoyberg snoyberg merged commit 14e89a7 into yesodweb:master Dec 19, 2016
@terickson001 terickson001 deleted the hamlet/class-id-spacing-fix branch December 19, 2016 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants