Skip to content

Conversation

@iand675
Copy link
Contributor

@iand675 iand675 commented Apr 9, 2019

  • Bumped the version number
  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

This adds a version of openSimpleConnWithVersion. Since I never use old versions of PostgreSQL that lack upsert support, I want to be able to avoid doing round trip checks of the version each time I create a connection via openSimpleConn.

Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@parsonsmatt parsonsmatt merged commit e939f23 into yesodweb:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants