Add NoAction to CascadeAction #1610
Conversation
| -- | ||
| -- @since 2.11.0 | ||
| data CascadeAction = Cascade | Restrict | SetNull | SetDefault | ||
| data CascadeAction = Cascade | Restrict | SetNull | SetDefault | NoAction |
There was a problem hiding this comment.
This is the core change, all other changes are in support of it.
There was a problem hiding this comment.
Because this adds a data constructor to an exported type, it is a breaking change, and needs a majoe bump
parsonsmatt
left a comment
There was a problem hiding this comment.
Changes are great! Some version bounds and cabal files to update but I can get this out very soon
| -- | ||
| -- @since 2.11.0 | ||
| data CascadeAction = Cascade | Restrict | SetNull | SetDefault | ||
| data CascadeAction = Cascade | Restrict | SetNull | SetDefault | NoAction |
There was a problem hiding this comment.
Because this adds a data constructor to an exported type, it is a breaking change, and needs a majoe bump
persistent/ChangeLog.md
Outdated
| @@ -1,5 +1,10 @@ | |||
| # Changelog for persistent | |||
|
|
|||
| # 2.17.2.0 | |||
There was a problem hiding this comment.
| # 2.17.2.0 | |
| # 2.18.0.0 |
There was a problem hiding this comment.
Also don't forget to update cabal file please!
persistent-postgresql/ChangeLog.md
Outdated
| @@ -1,5 +1,10 @@ | |||
| # Changelog for persistent-postgresql | |||
|
|
|||
| # 2.14.1.0 | |||
There was a problem hiding this comment.
| # 2.14.1.0 | |
| # 2.14.0.1 |
| , postgresql-simple:base | ||
| , postgresql-simple:template-haskell | ||
| , bytestring-lexing:base | ||
| , postgresql-simple-interval:persistent |
There was a problem hiding this comment.
Added this to avoid the upper-bound that this library has on persistent, which blocks the build.
|
hell yeah |
Before submitting your PR, check that you've:
fourmoluon any changed files (restyledwill do this for you, soaccept the suggested changes if it makes them)
.editorconfigandfourmolu.yamlfiles for details)After submitting your PR:
(unreleased)on the ChangelogThis PR adds NoAction as a CascadeAction, so that we can tag foreign keys with this cascade option.