Skip to content

Conversation

@Vekhir
Copy link
Contributor

@Vekhir Vekhir commented Sep 12, 2023

Builds and tests fine

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@parsonsmatt
Copy link
Collaborator

I've made Hackage Revisions to this effect. Thanks!

@Vekhir
Copy link
Contributor Author

Vekhir commented Sep 18, 2023

Do Hackage revisions need some time? I don't see the revisions on either 2.13.5.2 nor 2.13.6.
Also unfortunate that this PR didn't make it into 2.13.6.

@parsonsmatt
Copy link
Collaborator

The Hackage revision is applied to 2.13.5.2. I see it on my end at least.

I did release 2.13.6 without merging this! My bad. I will make another revision there.

@parsonsmatt parsonsmatt merged commit a3a25eb into yesodweb:master Sep 19, 2023
@Vekhir
Copy link
Contributor Author

Vekhir commented Sep 19, 2023

The Hackage revision is applied to 2.13.5.2. I see it on my end at least.

Now I can see it too. The version from few minutes ago (that I still have open) didn't have it. Just takes time for all servers I guess.

I did release 2.13.6 without merging this! My bad. I will make another revision there.

Unfortunate! But thanks for merging it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants