Explicitly import Control.Monad.Trans for mtl-2.3 compat #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Please add a changelog entry and version bump and I'll be happy to get this merged + released. Thank you! |
mtl-2.3.1 no longer re-exports this from another module
Contributor
Author
|
Sure I've force pushed adding a changelog entry and a patch version bump. |
Collaborator
|
Great thanks! Super minor request: in the future, for larger PRs, please don't force-push - it makes "view changes since last commit" unusable, which makes reviewing PRs harder. I do a squash+merge to keep the commit history clean. |
Contributor
Author
|
Sure no worries! I'll keep that in mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to make this change to have this module compile with GHC-9.6.1-alpha1.
I see that there is already an mtl-2.3 compat branch merged, so I'm not sure why this wasn't picked up there.
Perhaps this was being re-exported by something else?