Skip to content

Make use of CautiousMigration type alias in SQL backends. #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parsonsmatt merged 1 commit into from
Jan 22, 2023
Merged

Make use of CautiousMigration type alias in SQL backends. #1459

parsonsmatt merged 1 commit into from
Jan 22, 2023

Conversation

@arrowd
Copy link
Contributor

@arrowd arrowd commented Jan 3, 2023

When reading migrate' implementations of persistent-sqlite and persistent-postgresql it took me a while to figure out what (Bool, Text) actually means. Using the type alias from Database.Persist.Sql.Migration makes it clearer.

@arrowd
Copy link
Contributor Author

arrowd commented Jan 12, 2023

Bump. This PR is trivial, can we get it merged in?

@parsonsmatt
Copy link
Collaborator

parsonsmatt commented Jan 12, 2023

sure! please update the changelog, bump the version bound, and I'll prepare a release.

@arrowd arrowd force-pushed the CautiousMigration branch from 33dceef to 0d93670 Compare January 12, 2023 19:25
@arrowd
Copy link
Contributor Author

arrowd commented Jan 12, 2023

Ouch, I should've bumped backend packages, not persistent itself, right?

@parsonsmatt
Copy link
Collaborator

parsonsmatt commented Jan 12, 2023

Yup - persistent only gets a changelog/bump when it changes. I don't want to keep everything in lock step.

@arrowd
* Make use of CautiousMigration type alias in SQL backends.
978c4f0 
* Bump persistent-mysql, persistent-postgresql and persistent-sqlite versions.

* Update respective changelogs.
@arrowd arrowd force-pushed the CautiousMigration branch from 0d93670 to 978c4f0 Compare January 12, 2023 19:46
@arrowd
Copy link
Contributor Author

arrowd commented Jan 17, 2023

Another bump.

@arrowd
Copy link
Contributor Author

arrowd commented Jan 22, 2023

It is disappointing to see such trivial PR taking so long to get in. I have other small changes in queue that I'm hoping to upstream.

@parsonsmatt
Copy link
Collaborator

parsonsmatt commented Jan 22, 2023

I understand your frustration. My work and personal situation do not leave much time or energy for OSS maintenance right now.

With this PR merged, your future PRs should automatically have CI run for them, which will speed things up a good bit.

For future PRs, please don't delete the PR template.

@parsonsmatt parsonsmatt merged commit 6fdbf84 into yesodweb:master Jan 22, 2023
@arrowd
Copy link
Contributor Author

arrowd commented Jan 22, 2023

I understand your frustration. My work and personal situation do not leave much time or energy for OSS maintenance right now.

Yes, we're all volunteers here. I appreciate the time you took for this review.

With this PR merged, your future PRs should automatically have CI run for them, which will speed things up a good bit.

For future PRs, please don't delete the PR template.

Ok, noted. Thanks!

@arrowd arrowd deleted the CautiousMigration branch January 22, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arrowd @parsonsmatt