Skip to content

Fix postgres add reference #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parsonsmatt merged 3 commits into from
Jun 18, 2021
Merged

Fix postgres add reference #1290

parsonsmatt merged 3 commits into from
Jun 18, 2021

Conversation

@parsonsmatt
Copy link
Collaborator

@parsonsmatt parsonsmatt commented Jun 18, 2021 •
edited
Loading

Before submitting your PR, check that you've:

  • Documented new APIs with Haddock markup
  • Added @since declarations to the Haddock
  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@parsonsmatt
Copy link
Collaborator Author

parsonsmatt commented Jun 18, 2021 •
edited
Loading

Closes #1279

parsonsmatt
parsonsmatt commented Jun 18, 2021
View reviewed changes
persistent-postgresql/Database/Persist/Postgresql.hs
->
[AddReference
(getEntityDBName edef)
(crTableName colRef)
Copy link
Collaborator Author

@parsonsmatt parsonsmatt Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual fix lol

@parsonsmatt
Copy link
Collaborator Author

parsonsmatt commented Jun 18, 2021

@codedmart want to give this a shot?

@parsonsmatt parsonsmatt merged commit 2aa65e2 into master Jun 18, 2021
@codedmart
Copy link

codedmart commented Jun 18, 2021

Ok I will try this out tomorrow morning. Thanks!

@codedmart
Copy link

codedmart commented Jun 19, 2021

@parsonsmatt Works perfect. Thanks, much appreciated!

@jezen jezen deleted the matt/fix-add-reference branch July 21, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parsonsmatt @codedmart