Skip to content

Split HaskellName and DBName for Entities, Fields, and Constraints #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parsonsmatt merged 1 commit into from
Jan 6, 2021
Merged

Split HaskellName and DBName for Entities, Fields, and Constraints #1174

parsonsmatt merged 1 commit into from
Jan 6, 2021

Conversation

@jessekempf-interos
Copy link
Contributor

@jessekempf-interos jessekempf-interos commented Dec 10, 2020 •
edited
Loading

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@jessekempf-interos jessekempf-interos force-pushed the split-dbname-type branch 6 times, most recently from ad496c9 to 94e7247 Compare December 11, 2020 21:41
@jessekempf-interos jessekempf-interos changed the title Split DBName into EntityName, FieldName, and ConstraintName Split HaskellName and DBName for Entities, Fields, and Constraints Dec 11, 2020
@jessekempf-interos
Copy link
Contributor Author

jessekempf-interos commented Dec 11, 2020

@parsonsmatt: I've added the HaskellName decomposition you asked for on FP Slack. Are we going to be calling this v2.12? If so I can go ahead and add the @since annotations to the Haddocks and so on.

@jessekempf-interos jessekempf-interos force-pushed the split-dbname-type branch 6 times, most recently from acffbdc to a4d9019 Compare December 11, 2020 22:40
@parsonsmatt parsonsmatt added this to the 2.12 milestone Dec 11, 2020
parsonsmatt
parsonsmatt approved these changes Jan 6, 2021
View reviewed changes
Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope af let's roll out

@parsonsmatt parsonsmatt merged commit 9c5febd into yesodweb:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parsonsmatt parsonsmatt parsonsmatt approved these changes

Assignees

No one assigned

Labels

breaking

Projects

None yet

Milestone

2.12

Development

Successfully merging this pull request may close these issues.

2 participants

@jessekempf-interos @parsonsmatt