Skip to content

Refactor PostgresJSON Tests #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parsonsmatt merged 14 commits into from
Apr 15, 2020
Merged

Refactor PostgresJSON Tests #1072

parsonsmatt merged 14 commits into from
Apr 15, 2020

Conversation

@JonathanLorimer
Copy link
Contributor

@JonathanLorimer JonathanLorimer commented Apr 12, 2020 •
edited
Loading

I wasn't sure how to put all of the db entry keys into scope. I made some ad hoc data structures to do so, but if anyone has any suggestions on how to do this better I would be open to them!

Note: I used runIO instead of before or beforeAll because I wanted to have access to the db entry keys. Additionally, I didn't insert the edgeCases when constructing the spec tree because they mess up some of the earlier tests. I had to insert the edgeCases in each it block afterwards, so I would still have access to the keys and they wouldn't pollute the db state.

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@JonathanLorimer JonathanLorimer mentioned this pull request Apr 12, 2020
Closed
parsonsmatt
parsonsmatt requested changes Apr 12, 2020
View reviewed changes
Copy link
Collaborator

@parsonsmatt parsonsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first pass! I think we can make some further improvements and that'll help.

@JonathanLorimer
Copy link
Contributor Author

JonathanLorimer commented Apr 15, 2020

@parsonsmatt I made the changes you request. I ended up just making all the tests work with the same setup, as I was having trouble adding a second beforeAll beneath the first one (types weren't checking). I think having the same setup is actually a cleaner approach anyways.

@parsonsmatt
Copy link
Collaborator

parsonsmatt commented Apr 15, 2020 •
edited
Loading

Fantastic, thanks! This is great work 😄

If you'd like, you can add a CHANGELOG entry for persistent-postgresql-2.11.0.0 linking to this PR and taking credit for the work 😄

@parsonsmatt
Copy link
Collaborator

parsonsmatt commented Apr 15, 2020

awesome thanks!

@parsonsmatt parsonsmatt merged commit 1dcd43d into yesodweb:master Apr 15, 2020
@JonathanLorimer
Copy link
Contributor Author

JonathanLorimer commented Apr 15, 2020

Thanks for your guidance on this Matt, I really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parsonsmatt parsonsmatt parsonsmatt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JonathanLorimer @parsonsmatt