Skip to content

Conversation

@parsonsmatt
Copy link
Collaborator

@parsonsmatt parsonsmatt commented Mar 30, 2020

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

A continuation on #1056 implementing it in Postgresql.

We can't implement this for MySQL until we figure out how to set a maxlen on the keys for strings. :\ Well, we could, but we'd need a different set of tests, and I don't feel like writing that out right now. Might as well get sqlite and postgres supported and released.

, foreignRefTableDBName :: !DBName
, foreignConstraintNameHaskell :: !HaskellName
, foreignConstraintNameDBName :: !DBName
, foreignFieldCascade :: !FieldCascade
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a field to a data type is a breaking change, so this PR will be for the 2.11.0 release.

@parsonsmatt parsonsmatt added this to the 2.11 milestone Mar 30, 2020
@parsonsmatt parsonsmatt merged commit 1b5747d into master Mar 30, 2020
@parsonsmatt parsonsmatt deleted the matt/cascade-merge branch March 31, 2020 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants