Merged
Conversation
snoyberg
reviewed
Jan 19, 2022
authenticate/authenticate.cabal
Outdated
| library | ||
| build-depends: base >= 4.10 && < 5 | ||
| , aeson >= 0.5 | ||
| , aeson >= 2.0 && < 2.1 |
Member
There was a problem hiding this comment.
I try to avoid adding lower bounds like this that will bifurcate packages. Would it be possible to update this PR to use CPP to support both old and new aeson?
Author
There was a problem hiding this comment.
Done, aeson < 2.0 is now supported as well.
snoyberg
reviewed
Jan 23, 2022
authenticate/authenticate.cabal
Outdated
| library | ||
| build-depends: base >= 4.10 && < 5 | ||
| , aeson >= 0.5 | ||
| , aeson >= 0.5 && < 1.6 || >= 2.0 && < 2.1 |
Member
There was a problem hiding this comment.
I'm not interested in adding upper bounds here, please remove.
snoyberg
reviewed
Jan 23, 2022
Author
|
Great. BTW, this PR fixes #54, so you could close that issue too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.