Fix: Inject workspace-local package maps for island node-modules scripts

cursoragent · cursoragent · commit 4869fa7c37e3 · 2026-06-18T18:49:41.000Z
When scripts run from island workspaces using node-modules linker,
NODE_OPTIONS now correctly points to the workspace-local package map
(workspace/node_modules/.package-map.json) instead of the root package
map. This ensures Node can resolve packages from the island's layout.

The fix detects when a script's package is a workspace in an island
with node-modules linker, removes any existing root package map from
NODE_OPTIONS, and injects the workspace-local map path.

Resolves bug where island maps were generated but never used by scripts,
causing resolution failures in mixed PnP root + island node-modules setups.
diff --git a/packages/zpm/src/script.rs b/packages/zpm/src/script.rs
@@ -749,6 +749,40 @@ impl ScriptEnvironment {
         self.binaries = self.binaries
             .with_package(&binaries, &project.project_cwd)?;
 
+        // If this package is a workspace in an island with node-modules linker,
+        // update NODE_OPTIONS to use the workspace-local package map instead of
+        // the root package map.
+        if project.config.settings.node_experimental_package_map.value {
+            if let Ok(workspace) = project.workspace_by_ident(&locator.ident) {
+                let in_nm_island = project.config.settings.unstable_islands
+                    .values()
+                    .any(|island| {
+                        island.linker.value == zpm_config::IslandLinker::NodeModules
+                            && island.workspaces.iter().any(|glob| glob.value.check(&workspace.name))
+                    });
+
+                if in_nm_island {
+                    let workspace_package_map_path = workspace.path
+                        .with_join_str("node_modules")
+                        .with_join_str(crate::project::PACKAGE_MAP_NAME);
+                    
+                    if workspace_package_map_path.if_exists().is_some() {
+                        // Remove any existing package-map option from NODE_OPTIONS
+                        if let Some(Some(node_options)) = self.env.get_mut("NODE_OPTIONS") {
+                            let updated = PACKAGE_MAP_MATCHER.replace_all(node_options, "").to_string();
+                            *node_options = updated;
+                        }
+                        
+                        // Add the workspace-local package map
+                        self.append_env("NODE_OPTIONS", ' ', &format!(
+                            "--experimental-package-map={}",
+                            quote_path_if_needed(&workspace_package_map_path.to_file_string())
+                        ));
+                    }
+                }
+            }
+        }
+
         Ok(self)
     }
 
