Skip to content

Hotfixes for the 1.22.20#9009

Merged
arcanis merged 6 commits into1.22-stablefrom
mael/1.22.20
Nov 14, 2023
Merged

Hotfixes for the 1.22.20#9009
arcanis merged 6 commits into1.22-stablefrom
mael/1.22.20

Conversation

@arcanis
Copy link
Copy Markdown
Member

@arcanis arcanis commented Nov 10, 2023 •
edited
Loading

Fixes #8793
Fixes #8965
Fixes #9005

  • Punycode is now embed within the bundle, as it has been deprecated by Node.js and will be removed in a future version.

  • A message will be displayed when Yarn 1.22 notices that the local project has a package.json file referencing a non-1.x Yarn release. The message will explain that the project is intended to be used with Corepack.

  • I removed the yarn-error.log generation. Given that we don't process non-critical 1.x bug reports, they are now mostly an annoyance.

  • The yarn set version x.y.z command will now install the exact x.y.z version (prior to this change it used to first install the latest version, and only in a second step would it downgrade to x.y.z; this was causing issues when we bump the minimal Node.js version we support, as running yarn set version 3.6.4 wouldn't work on Node 16).

  • Prevents crashes when reading from an empty .yarnrc.yml file.

@arcanis arcanis changed the title Hotfixes for the 1.22.10 Hotfixes for the 1.22.20 Nov 14, 2023
@arcanis arcanis merged commit efdccc1 into 1.22-stable Nov 14, 2023
@arcanis arcanis deleted the mael/1.22.20 branch November 14, 2023 09:22
This was referenced Nov 14, 2023
Closed
Closed
Closed
@voslartomas
Copy link
Copy Markdown

voslartomas commented Nov 14, 2023 •
edited
Loading

@arcanis Hello it seems like latest version of yarn brings regression, it cannot find nearest package.json file. So having package.json in root of the project and trying to run yarn in any subfolder will raise error like this

Error: Couldn't find a package.json file in

Downgrade to v1.20.19 resolves this issue.

@arcanis
Copy link
Copy Markdown
Member Author

arcanis commented Nov 14, 2023

Can you give me a reproduction? According to your post the following should crash, but doesn't for me:

cd $(mktemp -d) && yarn init -y && yarn install && mkdir foo && cd foo && yarn install

@Cyberboss
Copy link
Copy Markdown

Cyberboss commented Nov 14, 2023

Dockerfile

FROM mcr.microsoft.com/dotnet/sdk:6.0-bookworm-slim AS build

# install node and npm
# replace shell with bash so we can source files
RUN curl --silent -o- https://raw.githubusercontent.com/creationix/nvm/v0.39.1/install.sh | sh

ENV NODE_VERSION 20.5.1

ENV NVM_DIR /root/.nvm
ENV NODE_PATH $NVM_DIR/v$NODE_VERSION/lib/node_modules
ENV PATH $NVM_DIR/versions/node/v$NODE_VERSION/bin:$PATH

RUN . $NVM_DIR/nvm.sh \
    && nvm install $NODE_VERSION \
	&& nvm use $NODE_VERSION \
  && npx --yes yarn add svg-to-ico@1.0.14 svg2img@1.0.0-beta.2

@Cyberboss
Copy link
Copy Markdown

Cyberboss commented Nov 14, 2023

#9011 (comment)

@Jolg42 Jolg42 mentioned this pull request Nov 15, 2023
Closed
@liuxingbaoyu
Copy link
Copy Markdown

liuxingbaoyu commented Nov 22, 2023 •
edited
Loading

Sorry for bothering.

#7939
It would be great if this could be fixed as well, this issue causes yarn1 to be completely unavailable on some Windows users.
Ref: typescript-eslint/typescript-eslint#6150

@shanemadden shanemadden mentioned this pull request Dec 6, 2023
Merged
@G-Rath G-Rath mentioned this pull request May 18, 2024
Closed
@mcmire mcmire mentioned this pull request Jun 21, 2024
Merged
@nzakas nzakas mentioned this pull request Jan 27, 2025
Closed
@jrmajor jrmajor mentioned this pull request Jul 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arcanis @voslartomas @Cyberboss @liuxingbaoyu @clhuang