Fix: Exception on windows with non-ascii character username#7940
Open
liuxingbaoyu wants to merge 2 commits intoyarnpkg:masterfrom
Open
Fix: Exception on windows with non-ascii character username#7940liuxingbaoyu wants to merge 2 commits intoyarnpkg:masterfrom
liuxingbaoyu wants to merge 2 commits intoyarnpkg:masterfrom
Conversation
Member
|
Can you please explain what the underlying cause is and why did you chose this specific solution? |
Author
|
@BYK The default encoding of cmd on some computers is not utf8. When encountering a non-ascii username, yarn will give an error, so I changed the encoding to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #7939: Exception on windows with non-ascii character username
Test plan
I modified the existing tests to make it pass.