Skip to content

Preserve workspace packages when adding to the root#4584

Closed
jgoz wants to merge 1 commit intoyarnpkg:masterfrom
jgoz:fix-workspace-add
Closed

Preserve workspace packages when adding to the root#4584
jgoz wants to merge 1 commit intoyarnpkg:masterfrom
jgoz:fix-workspace-add

Conversation

@jgoz
Copy link
Copy Markdown
Contributor

@jgoz jgoz commented Sep 29, 2017

Summary

Fixes #4348

Before this, adding a dev dependency to the workspace root would clear out workspace dependencies from yarn.lock. This is because ignoreWorkspaces was being set to true when executing add in the workspace root.

Test plan

  • Added new test
  • Existing tests pass
  • Manually tested in repro project

@buildsize
Copy link
Copy Markdown

buildsize bot commented Sep 29, 2017

This change will decrease the build size from 9.83 MB to 9.83 MB, a decrease of 426 bytes (0%)

File name Previous Size New Size Change
yarn-[version].noarch.rpm 848.45 KB 848.37 KB -81 bytes (0%)
yarn-[version].js 3.74 MB 3.74 MB -18 bytes (0%)
yarn-legacy-[version].js 3.79 MB 3.79 MB -18 bytes (0%)
yarn-v[version].tar.gz 854.17 KB 854.11 KB -59 bytes (0%)
yarn_[version]all.deb 645.48 KB 645.24 KB -250 bytes (0%)

@BYK BYK self-assigned this Sep 29, 2017
@arcanis arcanis assigned arcanis and unassigned BYK Sep 29, 2017
@arcanis
Copy link
Copy Markdown
Member

arcanis commented Sep 29, 2017

@kaylieEB would you mind reviewing this PR? I think it goes against what you did in #4278, I think you'll be more capable than us to make sure this commit doesn't make regression on the previous bug 😃

@jgoz
Copy link
Copy Markdown
Contributor Author

jgoz commented Sep 29, 2017

This is superseded by #4583.

@jgoz jgoz closed this Sep 29, 2017
@jgoz jgoz deleted the fix-workspace-add branch October 17, 2017 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants