Delay visibility propagation until deps are known#1739
Merged
sebmck merged 1 commit intoyarnpkg:masterfrom Nov 11, 2016
Merged
Conversation
Contributor
Author
|
Also tried this out against a non-trivial internal app that previously broke. Seems to work with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Right now visibility is set before the dependencies are added to the package reference. This means that no visibility information propagates for other requests for the same package. Example:
is-glob@^2.0.0is encountered. Visibility for the request is "env hidden"is-glob@^2.0.0are walked and inherit the visibility from their parentis-glob@^2.0.1is encountered. Visibility for the request is "used"addVisibilityis called - but at this point the dependencies are not yet resolvedTest plan
I couldn't figure out a good unit test for this. What I did for manual testing in an empty directory:
Fixes #761