Closed
Conversation
Member
Author
|
Unfortunately this rule seems to transform quotes in cases that TypeScript doesn't support yet 😢 |
Closed
5 tasks
Member
Author
|
Closing for now since I can't do it at the moment, but I'll retry with TypeScript 3.7 which should have better support for backticks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff enforces a consistent use of backticks across all files.
I favor backticks over other quotes since they lead to easier refactorings when variables are added/removed, rarely cause issues because of their content (like adding or removing a quote within a string), and shouldn't have any measurable impact on the runtime performances.