Skip to content

fix(git,github): skip prepareExternalProject when enableScripts=false#6280

Draft
legobeat wants to merge 9 commits intoyarnpkg:masterfrom
legobeat:consistent-enable-scripts
Draft

fix(git,github): skip prepareExternalProject when enableScripts=false#6280
legobeat wants to merge 9 commits intoyarnpkg:masterfrom
legobeat:consistent-enable-scripts

Conversation

@legobeat
Copy link
Copy Markdown

@legobeat legobeat commented May 7, 2024

What's the problem this PR addresses?

It seems that the purpose of prepareExternalProject in scriptUtils.ts is to execute lifecycle scripts of fetched packages.

This disables calling the function and calling out to external package managers when the configuration enableScripts is set to false.

Related

How did you fix it?

  • plugin-github: skip prepareExternalProject when configuration enableScripts is set to false
  • plugin-git: skip prepareExternalProject when configuration enableScripts is set to false

Checklist

  • I have set the packages that need to be released for my changes to be effective.
    • Not certain if I got this right - I put all prompted as patch
  • I will check that all automated PR checks pass before the PR gets reviewed.

@legobeat legobeat force-pushed the consistent-enable-scripts branch from 270b21d to 138d9ed Compare May 7, 2024 10:41
@legobeat legobeat force-pushed the consistent-enable-scripts branch from 138d9ed to 26e8146 Compare May 7, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: lifecycle script triggering despite enableScripts=false

1 participant