fix(git,github): skip prepareExternalProject when enableScripts=false#6280
Draft
legobeat wants to merge 9 commits intoyarnpkg:masterfrom
Draft
fix(git,github): skip prepareExternalProject when enableScripts=false#6280legobeat wants to merge 9 commits intoyarnpkg:masterfrom
legobeat wants to merge 9 commits intoyarnpkg:masterfrom
Conversation
4 tasks
270b21d to
138d9ed
Compare
138d9ed to
26e8146
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
It seems that the purpose of
prepareExternalProjectinscriptUtils.tsis to execute lifecycle scripts of fetched packages.This disables calling the function and calling out to external package managers when the configuration
enableScriptsis set tofalse.Related
How did you fix it?
plugin-github: skipprepareExternalProjectwhen configurationenableScriptsis set tofalseplugin-git: skipprepareExternalProjectwhen configurationenableScriptsis set tofalseChecklist
patch