Conversation
13 tasks
Member
|
API-wise, what about turning it into a getter named |
workspace.dependencies with getPackageworkspace.dependencies with worskpace.anchoredPackage
Member
Author
|
I like this idea, even though I generally don't like getters. I've updated the PR 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
I don't like
workspace.dependenciesbecause theProjectclass has to manually keep it in sync (and historically it hasn't done a good job).How did you fix it?
I removed it and added a new
workspace.anchoredPackagegetter that can be used in more situations.Since there is only one production codepath using
workspace.dependenciesand it accesses it a single time, the lack of caching forworkspace.anchoredPackagedoesn't affect its performance.Checklist