Add export fields to manifests to prevent deep imports#4834
Add export fields to manifests to prevent deep imports#4834arcanis merged 11 commits intoyarnpkg:masterfrom
export fields to manifests to prevent deep imports#4834Conversation
Also made sure to export some utils that may not have been exported before.
export fields to manifests to prevent deep importsexport fields to manifests to prevent deep imports
|
I converted the PR to a draft since that's what the title said it was. |
|
Thanks I tried to look for the button for that but I guess I just missed it. |
|
I am not too sure how to fix |
|
I think that I tried adding it only to the |
make the `gatsby-node.js` fix more simple.
|
The only real question I have left for this PR is was flagging all affected packages as a major change right? I figured as it blocks deep imports that it likely should be counted as such. |
merceyz
left a comment
There was a problem hiding this comment.
According to https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing we don't need the types condition since the .d.ts file is next to the .js file.
The only real question I have left for this PR is was flagging all affected packages as a major change right? I figured as it blocks deep imports that it likely should be counted as such.
Yeah, this is a breaking change so major is correct.
removed `./sync` and `./async` from `@yarnpkg/libzip` Normalized some Command Class names.
|
I have had issues when the |
export the command from `@yarnpkg/shell`
Typescript can find the type definition files without these helpers.
|
I think we can go with the removes |
|
|
||
| // eslint-disable-next-line arca/no-default-export | ||
| export default class PluginListCommand extends BaseCommand { | ||
| export default class PluginRuntimeCommand extends BaseCommand { |
There was a problem hiding this comment.
Thanks for cleaning all this, btw!
Todo:
typesconditionWhat's the problem this PR addresses?
This is help with 4.x as requested in #3591
This addresses the task
Add export fields to our manifests to prevent deep importsHow did you fix it?
Added exports to all manifests.
Added exports for some things that were not exported before.
Checklist