refactor(libui)!: require renderForm streams to be specified#4589
Merged
paul-soporan merged 2 commits intomasterfrom Jun 29, 2022
Merged
refactor(libui)!: require renderForm streams to be specified#4589paul-soporan merged 2 commits intomasterfrom
renderForm streams to be specified#4589paul-soporan merged 2 commits intomasterfrom
Conversation
13 tasks
merceyz
approved these changes
Jun 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
4.x TODO item: make
renderForm's streams required so that people don't forget to specify custom streams. This is consistent with what we do in other parts of the codebase that accept streams.How did you fix it?
Made the
optionsargument required.Checklist