Merged
Conversation
This comment has been minimized.
This comment has been minimized.
30a3b02 to
c2b775c
Compare
paul-soporan
requested changes
Oct 15, 2021
Member
paul-soporan
left a comment
There was a problem hiding this comment.
Just finished a quick review - I looked at a bit of everything except the tests.
I'll do a more in-depth review (including the tests) once you resolve these comments.
Nit: In the PR description you wrote Optional peer dependencies don't have their checksum computed nor stored., it should be Conditional dependencies.
Co-authored-by: Paul Soporan <paul.soporan@gmail.com>
Co-authored-by: Paul Soporan <paul.soporan@gmail.com>
Co-authored-by: Paul Soporan <paul.soporan@gmail.com>
merceyz
reviewed
Oct 17, 2021
paul-soporan
approved these changes
Oct 17, 2021
Member
Author
|
I released this change in |
3 tasks
Member
|
Reverted the avoidable breaking changes in #3612 so plugin authors shouldn't notice much if they're not using |
This was referenced Apr 11, 2022
3 tasks
2 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Fixes #3317
How did you fix it?
I'll write in more details tomorrow, but in a few words:
supportedArchitecturessetting.--check-cachewill still validate them, for zero-install users.Note that while it contains breaking changes, I plan to land it as a minor. This is due to multiple factors:
Checklist