Skip to content

fix: parse options ending with 3+ hyphens#434

Merged
bcoe merged 6 commits intoyargs:mainfrom
0x2b3bfa0:main
Jul 5, 2022
Merged

fix: parse options ending with 3+ hyphens#434
bcoe merged 6 commits intoyargs:mainfrom
0x2b3bfa0:main

Conversation

@0x2b3bfa0
Copy link
Contributor

@0x2b3bfa0 0x2b3bfa0 commented Feb 5, 2022

Options ending with three or more hyphens were being parsed as positional arguments because the options without key name regular expression didn't have a ^ beginning anchor.

@0x2b3bfa0
fix: parse options ending with 3+ hyphens
31d637a 
Before this commit, options ending with three or more hyphens were
being parsed as positional arguments, because a regular expression
didn't have a start anchor.

Closes yargs#433
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Feb 15, 2022
Closed
bcoe
bcoe requested changes Feb 27, 2022
View reviewed changes
@0x2b3bfa0 0x2b3bfa0 requested a review from bcoe February 27, 2022 20:24
@0x2b3bfa0

This comment was marked as outdated.

Sign in to view
@bcoe
Copy link
Member

bcoe commented Jun 5, 2022

@0x2b3bfa0 this fix looks good to me, but I believe you've created your PR against the branch yargs:main rather than main, mind switching the branch you've created your pull against?

@0x2b3bfa0
Copy link
Contributor Author

0x2b3bfa0 commented Jun 5, 2022 •
edited
Loading

@bcoe, yargs:main means “the branch main under the yargs user or organization” as opposed to 0x2b3bfa0:main, which means “the branch main under the 0x2b3bfa0 user's fork” 🤔

It looks like this pull request should be safe to merge (?)

@0x2b3bfa0
Copy link
Contributor Author

0x2b3bfa0 commented Jun 6, 2022

Continuous integration checks are red. Is it my fault, or just a transient issue? 🤔

@bcoe
Copy link
Member

bcoe commented Jun 20, 2022 •
edited
Loading

@0x2b3bfa0 It's not immediately clear to me what the regression might be, it might not be related to your code changes -- unfortunately it might be a little while until I can fix up tests.

Apologies for the delay on review.

@0x2b3bfa0
Copy link
Contributor Author

0x2b3bfa0 commented Jun 21, 2022

@bcoe, #442 fixes the tests

@bcoe bcoe merged commit 4f1060b into yargs:main Jul 5, 2022
@github-actions github-actions bot mentioned this pull request Jul 5, 2022
Merged
@bcoe
Copy link
Member

bcoe commented Jul 5, 2022

@0x2b3bfa0 thank you for the patch 🥳 apologies for the slow turn around.

@0x2b3bfa0
Copy link
Contributor Author

0x2b3bfa0 commented Jul 7, 2022

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcoe bcoe bcoe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Option with three or more trailing hyphens parsed as positional argument

2 participants

@0x2b3bfa0 @bcoe