fix: Use decamelize from npm instead of vendored copy #1377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bcoe yargs-parser already depends on decamelize@1.2.0 (and it's always
require()'ed). So this doesn't add anything to the node_modules directory and it avoids loading two copies of decamelize into memory by making yargs and yargs-parser use the same module.Note that
decamelize@3is available (requires node.js 6). This is not used because it pulls inxregexpfor unicode regex support (9.5MB!!). xregexp will be dropped in a future version when node.js 10 is required.