Skip to content

fix: cannot find package.json on ESM#2123

Merged
bcoe merged 3 commits intoyargs:mainfrom
jopemachine:fix-pkg-notfound-issue-on-esm
May 14, 2022
Merged

fix: cannot find package.json on ESM#2123
bcoe merged 3 commits intoyargs:mainfrom
jopemachine:fix-pkg-notfound-issue-on-esm

Conversation

@jopemachine
Copy link
Contributor

@jopemachine jopemachine commented Jan 27, 2022 •
edited
Loading

Fixes #2122.

In the case of ava, mainFilename changes like below way.

// existing code's value:
mainFilename: /usr/local/lib/

// this PR's value:
mainFilename: /usr/local/lib/node_modules/ava/

This enable yargs to find ava's package.json properly.

@jly36963 jly36963 requested a review from bcoe March 26, 2022 15:44
@bcoe
Copy link
Member

bcoe commented Mar 28, 2022

@jopemachine I don't fully understand this fix, is the issue that there are multiple instances of node_modules in the path?

@jopemachine
Copy link
Contributor Author

jopemachine commented Mar 29, 2022

I don't fully understand this fix, is the issue that there are multiple instances of node_modules in the path?

Yes, as I mentioned in this comment, node_modules appears more than once in the path (__dirname).

So, existing code can't find proper mainFilename, package.json, that's why globally installed this module's version command prints unknown.

@jamescdavis
Copy link

jamescdavis commented May 10, 2022 •
edited
Loading

@bcoe I tested this fix and I can confirm that it fixes the issue. Seems like a good solution. Hopefully this can be merged and released soon. 🙂

@jamescdavis jamescdavis mentioned this pull request May 10, 2022
Closed
@bcoe bcoe merged commit e0823dd into yargs:main May 14, 2022
@bcoe
Copy link
Member

bcoe commented May 14, 2022

@jopemachine nit, it would be nice to have a test for this, but going ahead and merging with the hopes of unblocking issues with ava.

apologies for the slow review.

@github-actions github-actions bot mentioned this pull request May 14, 2022
Merged
@jamescdavis jamescdavis mentioned this pull request May 16, 2022
Merged
This was referenced Sep 6, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcoe bcoe bcoe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

yargs cannot find package.json on ESM

4 participants

@jopemachine @bcoe @jamescdavis @jly36963