fix(pkg): ship all .d.ts files in npm package#258
Merged
Conversation
The `files` whitelist only shipped `lib-es5/index.d.ts`, but that file imports from `./types`, so TypeScript consumers of the typed `exec()` API introduced in #253 couldn't resolve the module. Switch to `lib-es5/*.d.ts` so every generated declaration is published. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fileswhitelist only includedlib-es5/index.d.ts, but that file re-exports from./types, so the compiledlib-es5/types.d.tswas excluded from the published tarball.exec(options)API added in feat(api): typed options object for exec() #253 hit an unresolved-module error when compiling against@yao-pkg/pkg@6.18.0.lib-es5/*.d.tsso every generated declaration ships.Context
Reported by @viceice in #253 (comment).
Verified against the published 6.18.0 tarball —
lib-es5/types.d.tsis missing.npm pack --dry-runon this branch now lists all.d.tsfiles, includingtypes.d.ts(4.0 kB).Test plan
yarn lintcleannpm pack --dry-runlistslib-es5/types.d.tsand every otherlib-es5/*.d.tsimport type { PkgExecOptions } from '@yao-pkg/pkg'without module-resolution errors🤖 Generated with Claude Code