Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jsx-eslint/eslint-plugin-react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.20.0
Choose a base ref
...
head repository: jsx-eslint/eslint-plugin-react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.20.1
Choose a head ref
  • 11 commits
  • 21 files changed
  • 8 contributors

Commits on May 8, 2020

  1. Configuration menu
    Copy the full SHA
    03df672 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2020

  1. [patch] relax JSX pragma regexp

    Fixes #2642.
    gfmio authored and ljharb committed May 17, 2020
    Configuration menu
    Copy the full SHA
    ef9a512 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2020

  1. [Fix] no-unused-prop-types: fix with typescript eslint parser

    Fixes #2569.
    
    Co-authored-by: Antoine <antoine.sauvage@melix.net>
    Co-authored-by: Jordan Harband <ljharb@gmail.com>
    eltonio450 and ljharb committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    13a863b View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. [Fix] forbid-dom-props, function-component-definition: fix schema…

    … typos
    
    Fixes #2665. Fixes #2666.
    mflorence99 authored and ljharb committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    78e48c8 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. Configuration menu
    Copy the full SHA
    45e482a View commit details
    Browse the repository at this point in the history
  2. [Dev Deps] update @types/eslint, @types/node, `@typescript-eslint…

    …/parser`, `eslint-config-airbnb-base`, `eslint-plugin-import`, `typescript`
    ljharb committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    fbd799c View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. Cache detected React version

    I've been timing and profiling ESLint runs at Airbnb and noticed that
    react/no-unknown-property is particularly slow for us when using the
    "detect" setting for React version.
    
    When running ESLint using TIMING=1 on a directory that contains about
    500 files to be linted in it, react/no-unknown-property shows up as
    taking about 1700ms.
    
    Looking at the callstacks in the profiler, it seems that when this rule
    calls getStandardName for every JSXAttribute here, it will actually do
    all of the work to detect the React version every time to determine the
    correct set of DOM property names. Since there may be a lot of
    JSXAttribute nodes in a codebase, this adds up to quite a bit of work.
    
    By specifying the react version in our ESLint config, the
    no-unkown-property rule drops out of the top 10 slowest rules entirely,
    with the 10th slowest clocking in at 180ms.
    
    I think it would be a good idea to cache the React version when using
    detect instead of looking it up every time.
    lencioni committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    b8e91a5 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. [Fix] forbid-prop-types: warn on destructured values as well

    Fixes #2662.
    
    Co-authored-by: Alex Kovar <ajkovar@gmail.com>
    Co-authored-by: Jordan Harband <ljharb@gmail.com>
    ajkovar and ljharb committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    997a99f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Configuration menu
    Copy the full SHA
    a4025bd View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2020

  1. [Dev Deps] update @types/eslint, @types/estree, @types/node, `e…

    …slint-plugin-eslint-plugin`, `eslint-plugin-import`
    ljharb committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    46cf771 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f5405f7 View commit details
    Browse the repository at this point in the history
Loading