Support unicode literals over codepoint 0xffff#65
Closed
adamchainz wants to merge 1 commit intoyaml:masterfrom
Closed
Support unicode literals over codepoint 0xffff#65adamchainz wants to merge 1 commit intoyaml:masterfrom
adamchainz wants to merge 1 commit intoyaml:masterfrom
Conversation
421c9b3 to
e7272cc
Compare
Author
|
I took #63, squashed the commits and removed the diff noise that I noted there. As I'm not a maintainer I couldn't puh to @peterkmurphy 's branch. Ping @sigmavirus24 |
|
Looks like a good enhancement! @sigmavirus24 what do you think of this? |
|
@sigmavirus24 any chance of reviewing this change? |
Author
|
I've solved a riddle from http://www.coglib.com/~icordasc/index.html#resume and directly emailed @sigmavirus24 with regards to this |
Contributor
|
This fix has been merged in the original pull request. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25. Rebase and tidy up of #63.