use text gitattributes and context managers for tests#542
Closed
mattip wants to merge 2 commits intoyaml:masterfrom
Closed
use text gitattributes and context managers for tests#542mattip wants to merge 2 commits intoyaml:masterfrom
mattip wants to merge 2 commits intoyaml:masterfrom
Conversation
Author
|
This Pr is awaiting approval to run |
Author
|
This PR needs approval to run CI |
Author
|
The build failed for python2.7 on macos since cibuildwheel no longer supports python2.7. I pinned the cibuildwheel version. Each new changeset needs approval to run CI |
Member
|
PS: there's nothing special about our GHA- we're just on the normal free plan, so if you're still needing to debug issues, you can do that on your own fork so I don't have to keep pushing the button 😆 |
Member
|
But yeah, I've hit the need to pin cibuildwheel in several places as well- I added the cibuildwheel version pin to the config matrix for cffi for the same reason... |
Author
|
Good idea. The last commit ran successfully in my fork. |
5 tasks
Author
|
This has too many conflicts with master, I will close it and try to redo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to get the pypy windows pyyaml-feedstock to run cleanly, I needed to make these changes
.gitattributesfile to tell git that the test data files are text (this was already in the feedstock but maybe not upstreamed?)open()into proper context managers so that the files were closed. This is important on PyPy + Windows when writing to files.I got a bit carried away and converted all of them, as long as I was making a PR, even though most of them are read-only so it doesn't really matter.