Skip to content

Making python 3.7 + compatible#212

Closed
Keyrat06 wants to merge 1 commit intoyaml:masterfrom
Keyrat06:patch-1
Closed

Making python 3.7 + compatible#212
Keyrat06 wants to merge 1 commit intoyaml:masterfrom
Keyrat06:patch-1

Conversation

@Keyrat06
Copy link
Copy Markdown

@Keyrat06 Keyrat06 commented Aug 16, 2018

Python warning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

@Keyrat06
Making python 3.7 + compatible
f92d859 
Python warning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
nitzmahone
nitzmahone approved these changes Aug 16, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@nitzmahone nitzmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works back to Python3.3, so LGTM

@webknjaz
Copy link
Copy Markdown

webknjaz commented Aug 23, 2018

Should I absorb this commit into #172, which also enables testing against proper Python 3.7?

@Keyrat06
Copy link
Copy Markdown
Author

Keyrat06 commented Aug 23, 2018

Sure, sounds good to me.

@webknjaz webknjaz mentioned this pull request Aug 23, 2018
Closed
@webknjaz
Copy link
Copy Markdown

webknjaz commented Aug 23, 2018

Done!

@tirkarthi tirkarthi mentioned this pull request Sep 20, 2018
Closed
@The-Compiler
Copy link
Copy Markdown
Contributor

The-Compiler commented Oct 24, 2018

Duplicate of #181 FWIW.

@webknjaz
Copy link
Copy Markdown

webknjaz commented Oct 24, 2018

@The-Compiler also absorbed into #172, which also enables testing. I hope it'll get reviewed and merged at some point

@naphthalene
Copy link
Copy Markdown

naphthalene commented Nov 19, 2018

LGTM! Is there a release planned?

@kishanterry
Copy link
Copy Markdown

kishanterry commented Jan 9, 2019

When is this PR expected to be merged and released?

@blazingkin
Copy link
Copy Markdown

blazingkin commented Jan 29, 2019

I would also like to know when this PR will be released

@ingydotnet
Copy link
Copy Markdown
Member

ingydotnet commented Jan 29, 2019

@blazingkin In the next release. Hopefully in February.

@stratosgear
Copy link
Copy Markdown

stratosgear commented Jan 31, 2019

Also looking forward for this.

The DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working warning, "pollutes" my tox outputs :)

@adrienverge adrienverge mentioned this pull request Feb 14, 2019
Closed
@et304383
Copy link
Copy Markdown

et304383 commented Feb 14, 2019

Can we please get this merged in?

@mgmacias95 mgmacias95 mentioned this pull request Feb 19, 2019
Closed
2 tasks
@perlpunk
Copy link
Copy Markdown
Member

perlpunk commented Dec 7, 2019

Is this still needed since #181 was merged already?

@webknjaz
Copy link
Copy Markdown

webknjaz commented Dec 8, 2019

You can close this one then

@perlpunk
Copy link
Copy Markdown
Member

perlpunk commented Dec 8, 2019

Thanks!

@perlpunk perlpunk closed this Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

+1 more reviewer

@drakmail drakmail drakmail approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.