Skip to content

Reverting https://github.com/yaml/pyyaml/pull/74#194

Closed
ingydotnet wants to merge 1 commit intomasterfrom
revert-74
Closed

Reverting https://github.com/yaml/pyyaml/pull/74#194
ingydotnet wants to merge 1 commit intomasterfrom
revert-74

Conversation

@ingydotnet
Copy link
Copy Markdown
Member

The reversion of the #74 code was without conflict against master.

This commit has been applied to the release/4.2 branch. See #193 for details of how the 4.2 release is proceeding and how this issue will make it back into PyYAML.


This reverts commit bbcf95f.
This reverts commit 7b68405.
This reverts commit 517e83e.

Revert "Make pyyaml safe by default."

This reverts commit bbcf95f.
This reverts commit 7b68405.
This reverts commit 517e83e.
@sigmavirus24
Copy link
Copy Markdown
Contributor

Outside of the normal cast of YAML contributors, the Python community has spoken to the fact that this is not a desirable change. At this point it seems like the people who are trying to contribute to this discussion as actual users of PyYAML have voiced their opinion and the rest of the YAML world has said "Nah, that's okay" which is exactly what is being signaled in this PR. Please, let's not ignore the users of this library who want their libraries to not allow RCEs by default.

@ingydotnet
Copy link
Copy Markdown
Member Author

@sigmavirus24 It should be clear, as I thought I think it is in #193 that a fix to this issue ( #74 / #189 ) is being worked on and will be released as soon as an agreed upon solution is available.

  • Make pyyaml safe by default. #74 is not acceptable in its current form.
  • It was introduced without my knowledge or approval.
  • That happened almost a year ago.
  • PyYAML has had safe options since the very beginning.
  • Exploitable use of it has been out there for 12+ years.

We can take a little time to find a win/win solution for both the YAML and Python communities. Hopefully that will happen in the 4.2 release. And if not, then shortly after.

I hope that people will join in to help out with the PyYAML release effort. Currently there are just 4 people trying their best to make this happen. Join irc.freenode.net #pyyaml

@sigmavirus24
Copy link
Copy Markdown
Contributor

@ingydotnet And this is why I've stopped working on the project. It's impossible to maintain something when one person needs to approve everything and the people doing the work don't have a say in how the work is done. This is why you have so few people trying to help you. Good luck.

@perlpunk
Copy link
Copy Markdown
Member

perlpunk commented Jul 1, 2018

@sigmavirus24 I think nobody's ignoring users here.
I would be very sad if the next version does not have a safe default, but:

@perlpunk
Copy link
Copy Markdown
Member

perlpunk commented Jul 1, 2018

@sigmavirus24

It's impossible to maintain something when one person needs to approve everything

I agree that we should not have a rule like that. It depends on the kind of PR, though.
In the end, there is a person or a group of persons responsible for the release, and everone of those should be aware of the changes. If it's a big API change, this should be discussed with everybody of the team.

the people doing the work don't have a say in how the work is done

I fail to see evidence for this. (But note that I started following pyyaml only a few months ago)

@sigmavirus24
Copy link
Copy Markdown
Contributor

It doesn't matter. I left the org. I'm abandoning this project. If someone is supposed to be the lead on a project, they're the lead on a project and should be able to make controversial decisions without needing everyone's permission who has ever been adjacent to the project. I'm ignoring this project, so mentioning me will no longer generate notifications.

@wimglenn
Copy link
Copy Markdown

wimglenn commented Aug 15, 2018

This is unfortunate. Removing a release from the index is a faux pas, PyPI should be considered immutable unless it's an emergency - better to release a 5.0 if it was deemed absolutely necessary to break from 4.x.

Copy link
Copy Markdown

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was fine as is

@perlpunk
Copy link
Copy Markdown
Member

merged in ccc40f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants