Skip to content

fix token name typos in comments#59

Closed
vszakats wants to merge 1 commit intoyaml:masterfrom
vszakats:typo
Closed

fix token name typos in comments#59
vszakats wants to merge 1 commit intoyaml:masterfrom
vszakats:typo

Conversation

@vszakats
Copy link
Copy Markdown
Contributor

@vszakats vszakats commented Jun 9, 2017

No description provided.

@vszakats vszakats changed the title token name typos in comments fix token name typos in comments Jun 9, 2017
@vszakats
Copy link
Copy Markdown
Contributor Author

Patch valid, but since it generated no interest, closing.

@vszakats vszakats closed this Jun 13, 2017
@vszakats vszakats deleted the typo branch August 28, 2017 00:34
@perlpunk
Copy link
Copy Markdown
Member

perlpunk commented Jun 28, 2018

@vszakats you could have left it open. If maintainers aren't reacting it doesn't mean they aren't interested in it, they just don't have time probably ;-)

@vszakats
Copy link
Copy Markdown
Contributor Author

@perlpunk Indeed! I prefer to close after a while to avoid having all the pending PRs piling up on the GitHub UI (I wish there was an 'archive' or 'forget' button there). I'm glad to reopen, in fact I upgraded my vendored copy of libyaml a few hours ago. I'm glad you picked up maintenance!

(To help vendored copy keepers, it'd be nice to have the libyaml version number #defines be rolled in the .h file directly instead of relying on make systems to s&r it into it. But I have no patch ready for this one :)

@vszakats
Copy link
Copy Markdown
Contributor Author

vszakats commented Jun 28, 2018

New PR here: #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants