Allow question marks in plain scalars in flow collections#105
Merged
perlpunk merged 1 commit intoyaml:release/0.2.5from Jun 1, 2020
Merged
Allow question marks in plain scalars in flow collections#105perlpunk merged 1 commit intoyaml:release/0.2.5from
perlpunk merged 1 commit intoyaml:release/0.2.5from
Conversation
This was referenced Feb 3, 2018
2718acb to
ca86cc0
Compare
Member
Author
|
Note: add test to yaml-test-suite: |
ingydotnet
approved these changes
May 21, 2020
ingydotnet
reviewed
May 31, 2020
Member
ingydotnet
left a comment
There was a problem hiding this comment.
@perlpunk Is it easy to allow foo?bar and foo? bar and foo bar?, but not allow foo ? bar or foo ?bar?
The latter ones seem like they would cause more confusion that they'd solve.
Member
Author
I think that's not so easy. |
See http://yaml.org/spec/1.1/#id907281 The question mark isn't mentioned as something special here, only ,[]{} This commit will allow [foo?bar] [foo ? bar] The PR does only change the behaviour when the question mark is in the middle or at the end of the string, not at the beginning, e.g. [?foo] is handled by a different part of the code.
ca86cc0 to
96f7638
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See http://yaml.org/spec/1.1/#id907281
The question mark isn't mentioned as something special here, only
,[]{}This commit will allow
The PR does only change the behaviour when the question mark is in the middle or at the end of the string, not at the beginning, e.g.
[?foo]is handled by a different part of the code.