Change LICENSE and NOTICE to Apache standards#6
Conversation
ingydotnet
left a comment
There was a problem hiding this comment.
@scottrigby Can you amend the commit message to use a subject 50 chars or less?
Please and Thank You!
|
Is there any updates to this? Thanks! |
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates the project's dual-license structure to follow a more standard format that license scanners can properly detect. The changes replace a custom LICENSE format with the full Apache License 2.0 text while moving licensing information to the NOTICE file.
- Replaces custom dual-license format with standard Apache License 2.0 text
- Consolidates copyright and licensing notices into the NOTICE file
- Maintains attribution for MIT-licensed files ported from libyaml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| LICENSE | Replaced with full Apache License 2.0 text instead of custom dual-license format |
| NOTICE | Updated to include consolidated copyright notices and MIT license attribution for specific files |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@scottrigby I can't request you as a reviewer, but could you please review my updates? |
ccoVeille
left a comment
There was a problem hiding this comment.
I feel like it's OK with the current project structure.
I might suggest something else later, but for now it's OK.
Here is what I meant. I asked Gemini to write a good response for it. |
|
This part is what is a bit problematic
I feel like it might be OK for now with the old files. But I would like to consider moving MIT licensed files to a separate folder in internal/libyaml then using Go aliases to import everything that needs it. |
Most scanners including GitHub could not properly detect the previous format - Adds full Apache License - Combines notices from both files into existing NOTICE file - The MIT licence from LICENSE is a permissively-licensed dependency - Removed unneeded text. A pointer and a short summary notice is sufficient for MIT permissively-licensed dependency - Follows Apache example NOTICE format per https://arc.net/l/quote/deyyhvsk Signed-off-by: Scott Rigby <scott@r6by.com>
Most scanners including GitHub could not properly detect the previous format