feat(iotevents): add literalString() and literalNumber() to Expression#30
Draft
yamatatsu wants to merge 4 commits intoiotevents-rest-binary-expressionsfrom
Draft
feat(iotevents): add literalString() and literalNumber() to Expression#30yamatatsu wants to merge 4 commits intoiotevents-rest-binary-expressionsfrom
yamatatsu wants to merge 4 commits intoiotevents-rest-binary-expressionsfrom
Conversation
4 tasks
f314748 to
cd89d06
Compare
a63fc40 to
bcda92d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
literalString()andliteralNumber().In this discussion, we considered to make breaking change for
fromString().But I thought it is better to keep
fromString()with current behavior, because this method is needed for escape-hatch to use some expressions that we have not implemented yet.Additionally, this behavior is same as appsync MappingTemplate.fromString(), so there is unity in these namings I think.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license