Use the name (d[0][0]) instead of the key in AF_initDataChunkQueue.#107
Merged
averissimo merged 2 commits intoyakyak:masterfrom Nov 7, 2018
Merged
Use the name (d[0][0]) instead of the key in AF_initDataChunkQueue.#107averissimo merged 2 commits intoyakyak:masterfrom
averissimo merged 2 commits intoyakyak:masterfrom
Conversation
…evant data in AF_initDataChunkQueue.
|
I tested this with yakyak master and it worked for me. Thanks again @HomerSp! For those who are interested, here's what I did: git clone https://github.com/yakyak/yakyak.git
cd yakyak
perl -i~ -ple '/hangupsjs/ and $_ = qq| "hangupsjs": "$ENV{PWD}/hangupsjs/",|' package.json
git clone https://github.com/HomerSp/hangupsjs.git
cd hangupsjs
git checkout work
cd ..
npm install
npm run gulp
npm run electron app |
|
Confirmed working on yakyak master on macOS Sierra 10.12.6 with similar steps, minus the Perl 😛 Edit: Interestingly though, it seems that the generated |
|
Confirming working using v1.5.3-beta-rolling on Mac OS X 10.11.6 El Capitan. I downloaded and installed the binary, then in Terminal did: Arriba! |
Contributor
|
I'm using hangupsjs for a custom bot, I rebased this PR, and I can confirm this works also for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a lot more reliable and will, hopefully, survive future server-side updates (like one last night).