Skip to content

Use the name (d[0][0]) instead of the key in AF_initDataChunkQueue.#107

Merged
averissimo merged 2 commits intoyakyak:masterfrom
HomerSp:work
Nov 7, 2018
Merged

Use the name (d[0][0]) instead of the key in AF_initDataChunkQueue.#107
averissimo merged 2 commits intoyakyak:masterfrom
HomerSp:work

Conversation

@HomerSp
Copy link
Copy Markdown
Contributor

@HomerSp HomerSp commented Nov 1, 2018

This should be a lot more reliable and will, hopefully, survive future server-side updates (like one last night).

@smammy
Copy link
Copy Markdown

smammy commented Nov 1, 2018

I tested this with yakyak master and it worked for me. Thanks again @HomerSp! For those who are interested, here's what I did:

git clone https://github.com/yakyak/yakyak.git
cd yakyak
perl -i~ -ple '/hangupsjs/ and $_ = qq|    "hangupsjs": "$ENV{PWD}/hangupsjs/",|' package.json
git clone https://github.com/HomerSp/hangupsjs.git
cd hangupsjs
git checkout work
cd ..
npm install
npm run gulp
npm run electron app

@mitchellnemitz
Copy link
Copy Markdown

mitchellnemitz commented Nov 2, 2018

Confirmed working on yakyak master on macOS Sierra 10.12.6 with similar steps, minus the Perl 😛

git clone https://github.com/yakyak/yakyak.git
cd yakyak
vim package.json
# Update hangupsjs version to: "git://github.com/HomerSp/hangupsjs.git#work"
npm install
npm run gulp
npm run electron app

Edit: Interestingly though, it seems that the generated YakYak.app fails to find hangupsjs module on launch...

@fulltrucker
Copy link
Copy Markdown

fulltrucker commented Nov 2, 2018

Confirming working using v1.5.3-beta-rolling on Mac OS X 10.11.6 El Capitan. I downloaded and installed the binary, then in Terminal did:

cd /Applications/YakYak.app/Contents/Resources/app/node_modules/hangupsjs
wget https://patch-diff.githubusercontent.com/raw/yakyak/hangupsjs/pull/107.patch
patch -p1 < 107.patch
rm -rf lib/*
npm i

Arriba!

@lorenzos
Copy link
Copy Markdown
Contributor

lorenzos commented Nov 5, 2018

I'm using hangupsjs for a custom bot, I rebased this PR, and I can confirm this works also for me.

@averissimo averissimo merged commit a9ae994 into yakyak:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants