Add missing -Infinity support

vthibault · vthibault · commit 4599ec6355db · 2020-02-12T13:00:02.000+01:00
diff --git a/index.js b/index.js
@@ -103,7 +103,7 @@ module.exports = function serialize(obj, options) {
             return '@__U-' + UID + '-' + (undefs.push(origValue) - 1) + '__@';
         }
 
-        if (origValue === Infinity) {
+        if (type === 'number' && !isNaN(origValue) && !isFinite(origValue)) {
             return '@__I-' + UID + '-' + (infinities.push(origValue) - 1) + '__@';
         }
 
@@ -209,7 +209,7 @@ module.exports = function serialize(obj, options) {
         }
 
         if (type === 'I') {
-            return 'Infinity';
+            return infinities[valueIndex];
         }
 
         var fn = functions[valueIndex];
diff --git a/test/unit/serialize.js b/test/unit/serialize.js
@@ -388,6 +388,16 @@ describe('serialize( obj )', function () {
             var d = eval(serialize(Infinity));
             expect(d).to.equal(Infinity);
         });
+
+        it('should serialize -Infinity', function () {
+            expect(serialize(-Infinity)).to.equal('-Infinity');
+            expect(serialize({t: [-Infinity]})).to.be.a('string').equal('{"t":[-Infinity]}');
+        });
+
+        it('should deserialize -Infinity', function () {
+            var d = eval(serialize(-Infinity));
+            expect(d).to.equal(-Infinity);
+        });
     });
 
     describe('XSS', function () {

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ module.exports = function serialize(obj, options) {`
`103`	`103`	`return '@__U-' + UID + '-' + (undefs.push(origValue) - 1) + '__@';`
`104`	`104`	`}`
`105`	`105`
`106`		`- if (origValue === Infinity) {`
	`106`	`+ if (type === 'number' && !isNaN(origValue) && !isFinite(origValue)) {`
`107`	`107`	`return '@__I-' + UID + '-' + (infinities.push(origValue) - 1) + '__@';`
`108`	`108`	`}`
`109`	`109`
`@@ -209,7 +209,7 @@ module.exports = function serialize(obj, options) {`
`209`	`209`	`}`
`210`	`210`
`211`	`211`	`if (type === 'I') {`
`212`		`- return 'Infinity';`
	`212`	`+ return infinities[valueIndex];`
`213`	`213`	`}`
`214`	`214`
`215`	`215`	`var fn = functions[valueIndex];`