Core std macros additions#5
Closed
yaahc wants to merge 2 commits intoexplicitly-export-core-and-std-macrosfrom
Closed
Core std macros additions#5yaahc wants to merge 2 commits intoexplicitly-export-core-and-std-macrosfrom
yaahc wants to merge 2 commits intoexplicitly-export-core-and-std-macrosfrom
Conversation
yaahc
commented
Dec 2, 2025
Comment on lines
+16
to
+18
| // I had hoped that this would not produce the globvsglob error because it would never be | ||
| // resolving `panic` via one of the ambiguous glob imports above but it appears to do so, not | ||
| // sure why |
Owner
Author
There was a problem hiding this comment.
I expected this to only have two candidates because both globs are in the same scope, so panic candidates should only exist in two scopes total and it should tiebreak to the prelude candidate.
b17cb42 to
03ee689
Compare
yaahc
commented
Dec 2, 2025
| && matches!(orig_ident.name, sym::panic) | ||
| && this.is_builtin_macro(binding.res()) | ||
| && this.is_builtin_macro(innermost_binding.res()); | ||
| && matches!(scope, Scope::StdLibPrelude) |
Owner
Author
There was a problem hiding this comment.
this handles the case where we're firing on two globs where neither is from the implicit prelude import (the glob vs multiouter test) and turning it into a hard error. We probably want this to be a warning but I think the tiebreak logic as I wrote it may be broken in this case and depend on import expansion order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.