new-log-viewer: Add support for exporting decoded logs as a file.#72
Merged
Henry8192 merged 26 commits intoy-scope:mainfrom Sep 23, 2024
Merged
new-log-viewer: Add support for exporting decoded logs as a file.#72Henry8192 merged 26 commits intoy-scope:mainfrom
Henry8192 merged 26 commits intoy-scope:mainfrom
Conversation
junhaoliao
requested changes
Sep 16, 2024
Co-authored-by: Junhao Liao <junhao@junhao.ca>
…ogs to utils folder
junhaoliao
requested changes
Sep 16, 2024
junhaoliao
reviewed
Sep 16, 2024
junhaoliao
requested changes
Sep 17, 2024
junhaoliao
requested changes
Sep 17, 2024
Member
junhaoliao
left a comment
There was a problem hiding this comment.
Looks really good. Let's address the final comments.
Co-authored-by: Junhao Liao <junhao@junhao.ca>
junhaoliao
reviewed
Sep 17, 2024
junhaoliao
reviewed
Sep 17, 2024
junhaoliao
reviewed
Sep 17, 2024
junhaoliao
reviewed
Sep 17, 2024
junhaoliao
reviewed
Sep 17, 2024
Member
|
How about changing the PR title to |
…filename class to CSS.
junhaoliao
reviewed
Sep 20, 2024
…xportProgress." This reverts commit 1e99e07.
junhaoliao
approved these changes
Sep 23, 2024
Member
I agree with Kirk's proposal of the PR title. |
This was referenced Sep 26, 2024
This was referenced Sep 27, 2024
This was referenced Sep 30, 2024
This was referenced Oct 14, 2024
This was referenced Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Add "Export Logs" button to download the current uncompressed logs.
The button triggers
exportLogsfunction defined inStateContextProvider, which posts aEXPORT_LOGworker request toMainWorker. The worker parses log events into chunks inloadChunkand postsCHUNK_DATAresponses back toStateContextProvider. It appends the posted log chunk usinglogExportManager, which triggers a download when it receives all log chunks.Validation performed
Click download button, the logs are downloaded with timestamped fileNames. Click download button multiple times, the logs are downloaded with different timestamps.