Skip to content

[WIP] Internal Storage using MySql#10

Closed
sitaowang1998 wants to merge 5 commits into
y-scope:mainfrom
sitaowang1998:storage
Closed

[WIP] Internal Storage using MySql#10
sitaowang1998 wants to merge 5 commits into
y-scope:mainfrom
sitaowang1998:storage

Conversation

@sitaowang1998

@sitaowang1998 sitaowang1998 commented Oct 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Add metadata and data storage components using MySql as storage backend.

Tasks

  • Add CMake build files for storage
  • Add general storage interface
  • Add Mysql implementation
  • Add tests

@coderabbitai

coderabbitai Bot commented Oct 27, 2024

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kirkrodrigues kirkrodrigues mentioned this pull request Oct 27, 2024
Merged
@sitaowang1998
Add depedency libraries and basic cmake structure.
64324fc 
Add catch2 as submodules and include fmt and spdlog as dependencies in
cmake. Add basic project structure like separation of core files with
components.
@sitaowang1998
storage: Add interface for storage.
86e4b47 
Added interface for metadata and storage interface. Added simple Task
and Data class for interface to work. Add boost header for uuid and
abseil for flat_hash_map.
@sitaowang1998
Storage: Split core into a library
e74d2d2
@sitaowang1998
storage: Add mariadb connector cpp as dependency
eba859f 
Replace mariadb-connector-c library with mariadb-connector-cpp.
@sitaowang1998
storage: Add mysql storage implementation
3f4ea05
@sitaowang1998 sitaowang1998 deleted the storage branch November 5, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sitaowang1998