WIP - Replace boost memory-mapped files with own implementation.#387
Closed
junhaoliao wants to merge 2 commits into
Closed
WIP - Replace boost memory-mapped files with own implementation.#387junhaoliao wants to merge 2 commits into
junhaoliao wants to merge 2 commits into
Conversation
Comment on lines
+128
to
+129
| size_t m_compressed_file_size; | ||
| char* m_mem_mapped_compressed_file_buffer; |
Member
There was a problem hiding this comment.
We should use std::span (probably wrapping with std::optional) instead
Member
If we do (2), then we should do (1). I think it would be a good idea to do both, but if we're time constrained, I think we could go with the current approach. If so, we can convert this to non-WIP and do a proper review. |
Member
|
This PR has been formally implemented in #445 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
When compiling the Zstd decompressor code with Emscripten for use in Log Viewer WebUI, it was identified that the code has dependency on Boost's memory-mapped files. That requires setting up extra compiling procedures - downloading Boost and also making modifications in Boost to avoid
emcccomplaining on missing some std::atomic implementations. However, the Boost dependencies can be replace with POSIX system calls.In Emscripten compiled example code, with the replacement the speedup is > 30 ms.
Description
This is WIP. Criticism is welcomed:
Validation performed
unitTesttarget and passed all: