Skip to content

Configure Presto settings in start_clp.py server_settings_json_updates #1260

@coderabbitai

Description

@coderabbitai

Description

The recent addition of Presto SQL query support in PR #1127 introduced new configuration settings in components/webui/server/settings.json:

  • ClpQueryEngine: "native"
  • PrestoHost: "localhost"
  • PrestoPort: 8889

These settings need to be properly configured in the server_settings_json_updates dictionary in components/clp-package-utils/clp_package_utils/scripts/start_clp.py to ensure consistency between the webui server configuration and the CLP startup script.

Current Status

The settings are currently hardcoded in settings.json but are not dynamically configured through the startup script's configuration management system.

Expected Behavior

The Presto-related settings should be configurable through the CLP configuration system and properly injected into the webui server settings during startup, similar to how other settings like database and MongoDB configurations are handled.

References

Metadata

Metadata

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions