Skip to content
This repository was archived by the owner on Dec 27, 2022. It is now read-only.

Add hooks to support customize-concurrency plugin.#87

Merged
westonruter merged 3 commits into
developfrom
feature/concurrency-hooks
Aug 28, 2016
Merged

Add hooks to support customize-concurrency plugin.#87
westonruter merged 3 commits into
developfrom
feature/concurrency-hooks

Conversation

@lgedeon

@lgedeon lgedeon commented Aug 28, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@coveralls

coveralls commented Aug 28, 2016

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 91.003% when pulling e853ab6 on feature/concurrency-hooks into 7d1e373 on develop.

Comment thread js/customize-snapshots.js
customizeUrl: customizeUrl,
uuid: component.data.uuid
uuid: component.data.uuid,
response: response

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Adds parity with the save event.

}

/** This filter is documented in wp-includes/class-wp-customize-manager.php */
$data = apply_filters( 'customize_save_response', $data, $this );

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite, as $this is CustomizeSnapshots\Customize_Snapshot_Manager not WP_Customize_Manager. So you should replace $this with $this->customize_manager.

@coveralls

coveralls commented Aug 28, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.03%) to 90.951% when pulling dacdf9b on feature/concurrency-hooks into 7d1e373 on develop.

@westonruter

Copy link
Copy Markdown
Contributor

Unit tests are failing because WordPress.org's SVN is down:

Installing WP from https://develop.svn.wordpress.org/trunk/ to /tmp/wordpress
svn: OPTIONS of 'https://develop.svn.wordpress.org/trunk': could not connect to server (https://develop.svn.wordpress.org)
dev-lib/check-diff.sh: line 336: /tmp/wordpress/src/wp-content/db.php: No such file or directory

@coveralls

coveralls commented Aug 28, 2016

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.03%) to 90.951% when pulling cad91c8 on feature/concurrency-hooks into 7d1e373 on develop.

@westonruter westonruter added this to the 0.6.0 milestone Aug 28, 2016
@westonruter westonruter merged commit b074773 into develop Aug 28, 2016
@westonruter westonruter deleted the feature/concurrency-hooks branch August 28, 2016 05:16
@westonruter

Copy link
Copy Markdown
Contributor

@lgedeon 👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants