This repository was archived by the owner on Dec 27, 2022. It is now read-only.
Add required PHP version go readme#160
Merged
Merged
Conversation
Contributor
|
@westonruter Shouldn't this be updated in the readme generator in dev-lib? |
Contributor
Author
|
@valendesigns updated in what way? |
Contributor
Author
|
The readme generator is copying “Requires PHP” into the markdown version. |
Contributor
|
Add |
Contributor
Author
|
It doesn't seem to be required because it works without it. |
Contributor
|
I see, so the readme generator is automatically adding |
Contributor
Author
|
I think the predefined list in the script just ensures that the same order is used when generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159.
See https://make.wordpress.org/plugins/2017/08/29/minimum-php-version-requirement/